fix(api): fill {{note}} in webhook bodies when an alert fires - #3645

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
hyperdx-oss	Ready	Preview	Nov 13, 2026 4:54am UTC
hyperdx-storybook	Ready	Preview	Nov 13, 2026 4:54am UTC

🦋 Changeset detected

Latest commit: f59eafb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

• Standard feature/fix — introduces new logic or modifies core functionality

Additional context: touches background tasks or the delivery pipeline lightly (1 lines, under the 30-line bar for Tier 4)

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

Duplicate code analysis

No new duplicate code introduced by this PR.

jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 108 in total (1.18%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

PR Review

✅ No issues found.

Deep Review

✅ No critical issues found.

This is a minimal, correctly-scoped bug fix. fireChannelEvent built templateView.alert without a note field, so the pre-existing consumer at packages/api/src/tasks/checkAlerts/template.ts:770 (note: alert.note ?? '') always resolved to an empty string on a real alert fire, and packages/api/src/tasks/checkAlerts/transports/generic.ts:105 then published {{note}} as empty. Adding note: alert.note at packages/api/src/tasks/checkAlerts/index.ts:555 completes the chain.

Verified during review:

• Types are sound. IAlert.note?: string | null flows through AlertInput into AlertMessageTemplateDefaultView.alert, and the consumer's ?? '' absorbs both null and undefined. No type error is introduced.
• incident.io is covered by the added test. WebhookService.IncidentIO dispatches through handleSendGenericWebhook (transports/index.ts:23), the same path the new Generic-webhook assertion exercises, so there is no separate untested note path.
• No injection risk. The note is JSON-escaped via escapeJsonString and passed as Handlebars view data (literal, not template source).
• No contract change. note was already a published webhook template variable; the diff only populates it on the fire path.
• Regression coverage is present. The TILE Generic-webhook integration test now asserts the delivered note in the body, which is the behavior being fixed.

Reviewers (9): correctness, testing, maintainability, project-standards, agent-native, learnings-researcher, security, api-contract, previous-comments.

E2E Test Results

✅ All tests passed • 467 passed • 1 skipped • 1370s

Tests ran across 4 shards in parallel.

View full report →